Skip to content

Remove duplicated coded in scheduler inheritance hierarchy #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 1 commit into from
Feb 13, 2026
Merged

Remove duplicated coded in scheduler inheritance hierarchy #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .../src/main/java/io/serverlessworkflow/impl/scheduler/ExecutorServiceWorkflowScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,10 @@
*/
package io.serverlessworkflow.impl.scheduler;

import io.cloudevents.CloudEvent;
import io.serverlessworkflow.impl.WorkflowDefinition;
import io.serverlessworkflow.impl.WorkflowModel;
import io.serverlessworkflow.impl.events.EventRegistrationBuilderInfo;
import java.time.Duration;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
import java.util.function.Function;

public abstract class ExecutorServiceWorkflowScheduler extends EventWorkflowScheduler {

Expand All @@ -32,15 +28,6 @@ public ExecutorServiceWorkflowScheduler(ScheduledExecutorService service) {
this.service = service;
}

@Override
public ScheduledEventConsumer eventConsumer(
WorkflowDefinition definition,
Function<CloudEvent, WorkflowModel> converter,
EventRegistrationBuilderInfo builderInfo) {
return new ScheduledEventConsumer(
definition, converter, builderInfo, new ScheduledInstanceRunnable(definition));
}

@Override
public Cancellable scheduleEvery(WorkflowDefinition definition, Duration interval) {
long delay = interval.toMillis();
Expand Down
4 changes: 4 additions & 0 deletions impl/core/src/main/java/io/serverlessworkflow/impl/scheduler/ScheduledInstanceRunnable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ public void run() {

@Override
public void accept(WorkflowModel model) {
runScheduledInstance(definition, model);
}

public static void runScheduledInstance(WorkflowDefinition definition, WorkflowModel model) {
WorkflowInstance instance = definition.instance(model);
definition.addScheduledInstance(instance);
definition.application().executorService().execute(() -> instance.start());
Expand Down