fix: updated S3 permissions and credential link#1166
Draft
fix: updated S3 permissions and credential link#1166
Conversation
- Added additional S3 permissions to IAM policy blocks based on recent troubleshoot.
- Added new IAM policy section to 'local/aws-s3'.
- Updated aws-batch and aws-eks existing policies.
- NOTES:
- s3:GetObjectTagging may not always be necessary (still investigating), but it makes sense to me to always include it since it ensures problems won't be encountered and does not worsen the security posture.
- Policies are defined x3. This should be made DRY but I dont know how to do this in framework, so I did a quick dumb implementation so clients dont get caught.
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
@christopher-hakkaart @llewellyn-sl -- I've converted this to draft while I wait for a troubleshooting client to confirm that this IAM fix truly got to end-of-job (we're pretty confident it's working since we bypassed the original S3 403 error, but I want official confirmation with this specific policy). |
justinegeffen
added
1. Editor review
Contributor
|
@gwright99, I have made some edits to fix one of the build errors related to trailing white spaces, you can safely ignore the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional S3 permissions to IAM policy blocks based on recent troubleshoot.
Fixed incorrect Credential link (pointed to Google, should have been pointing to AWS).
NOTES: