Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Refactors main.swift to remove duplication in how the app schedules its self-termination after sending a notification or when launched for a stale click, by centralizing the pattern into a helper.
Changes:
- Extracted duplicated
DispatchWorkItem+DispatchQueue.main.asyncAftertermination scheduling intoscheduleTermination(after:). - Updated both call sites to use the new helper.
Comments suppressed due to low confidence (1)
Sources/main.swift:245
- scheduleTermination assigns to global
terminationWorkand then force-unwraps it when scheduling (terminationWork!). This unwrap is unnecessary and makes the helper more brittle if it’s edited later. Prefer creating a localDispatchWorkItem, assign it toterminationWork, and pass the local variable toasyncAfter(optionally canceling any existingterminationWorkbefore overwriting).
func scheduleTermination(after seconds: TimeInterval) {
terminationWork = DispatchWorkItem { NSApplication.shared.terminate(nil) }
DispatchQueue.main.asyncAfter(deadline: .now() + seconds, execute: terminationWork!)
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tion Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scheduleTermination(after:)helperTest plan
./scripts/test.shpasses (16 tests)🤖 Generated with Claude Code