feat(metrics): migrate x/oracle, x/epoch, x/mint to OpenTelemetry#3439
Merged
amir-deris merged 2 commits intoMay 15, 2026
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
amir-deris
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3439 +/- ##
=======================================
Coverage 59.31% 59.31%
=======================================
Files 2120 2124 +4
Lines 175523 175567 +44
=======================================
+ Hits 104106 104141 +35
- Misses 62338 62343 +5
- Partials 9079 9083 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
bdchatham
approved these changes
May 14, 2026
Contributor
bdchatham
left a comment
bdchatham
left a comment
There was a problem hiding this comment.
Generally looks good to me. I think there are similar, very small improvements to use constants or one-time initialized vals for our dimensions to prevent from instantiating an identical copy every time we collect a metric but it's a non-blocker
masih
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds OTel instrumentation to x/oracle, x/epoch, and x/mint following the same pattern as PLT-329 (#3396) and PLT-330 (#3423). Legacy calls are kept with dual-emit until dashboards are verified (tracked in PLT-336).
New instruments
x/oracle (meter
oracle)oracle_mid_blocker_duration— histogram, seconds, fine-grained bucketsoracle_end_blocker_duration— histogram, seconds, fine-grained bucketsoracle_price_update— counter,denomlabelx/oracle/keeper (meter
oracle_keeper)oracle_vote_penalty_count— gauge,validator+type(miss/abstain/success) labelsoracle_validator_slashed— counter,validator+typelabelsx/epoch/keeper (meter
epoch_keeper)epoch_begin_blocker_duration— histogram, seconds, fine-grained bucketsepoch_new— gauge, current epoch numberx/mint/types (meter
mint)mint_coins_minted— gauge,denomlabelNote
Low Risk
Primarily adds instrumentation (new OTel meters and metric emissions) with dual-emitting legacy metrics; minimal behavioral change beyond extra work in hot paths (begin/mid/end blockers).
Overview
Adds OpenTelemetry instrumentation for
x/oracle,x/oracle/keeper,x/epoch/keeper, andx/mint/types, introducing new histograms/counters/gauges for blocker durations, epoch transitions, mint amounts, oracle price updates, vote penalty counts, and validator slashes.Updates the relevant execution points (epoch begin blocker, oracle mid/end blockers, oracle vote-penalty updates/deletes, oracle slashing, and mint success recording) to emit the new OTel metrics while temporarily dual-emitting the existing
telemetry/utils/metricsmetrics behindTODO(PLT-336)for dashboard verification.Reviewed by Cursor Bugbot for commit 36215f2. Bugbot is set up for automated code reviews on this repo. Configure here.