Skip to content

tmproto.Header -> sdk.Header#2933

Draft
pompon0 wants to merge 19 commits intomainfrom
gprusak-execute2
Draft

tmproto.Header -> sdk.Header#2933
pompon0 wants to merge 19 commits intomainfrom
gprusak-execute2

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Feb 19, 2026

sei-cosmos unnecessarily depends on tmproto.Header and uses it in a degenerate way.

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 19, 2026, 1:31 PM

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 78.08219% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.36%. Comparing base (2a1ccca) to head (87e5c60).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
sei-cosmos/x/simulation/mock_tendermint.go 0.00% 4 Missing ⚠️
app/export.go 0.00% 2 Missing ⚠️
app/test_helpers.go 33.33% 2 Missing ⚠️
sei-cosmos/baseapp/baseapp.go 81.81% 2 Missing ⚠️
sei-cosmos/x/simulation/simulate.go 0.00% 2 Missing ⚠️
app/apptesting/test_suite.go 66.66% 1 Missing ⚠️
sei-ibc-go/testing/simapp/export.go 0.00% 1 Missing ⚠️
sei-ibc-go/testing/simapp/test_helpers.go 0.00% 1 Missing ⚠️
sei-wasmd/app/test_helpers.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2933      +/-   ##
==========================================
+ Coverage   57.33%   57.36%   +0.03%     
==========================================
  Files        2089     2095       +6     
  Lines      172126   172866     +740     
==========================================
+ Hits        98683    99164     +481     
- Misses      64646    64821     +175     
- Partials     8797     8881      +84     
Flag Coverage Δ
sei-chain 52.86% <62.50%> (+0.05%) ⬆️
sei-cosmos 48.20% <81.81%> (+<0.01%) ⬆️
sei-db 68.42% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/abci.go 66.92% <100.00%> (ø)
app/app.go 71.31% <ø> (-1.43%) ⬇️
occ_tests/utils/utils.go 85.43% <100.00%> (ø)
sei-cosmos/baseapp/abci.go 66.21% <100.00%> (-0.06%) ⬇️
sei-cosmos/baseapp/test_helpers.go 76.92% <100.00%> (ø)
sei-cosmos/testutil/context.go 80.00% <100.00%> (ø)
sei-cosmos/types/context.go 93.67% <100.00%> (-0.15%) ⬇️
sei-cosmos/x/staking/types/historical_info.go 71.42% <100.00%> (ø)
sei-cosmos/x/upgrade/client/testutil/suite.go 100.00% <100.00%> (ø)
sei-ibc-go/testing/chain.go 93.98% <100.00%> (ø)
... and 16 more

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

func (s *KeeperTestHelper) Setup() {
s.App = app.Setup(s.T(), false, false, false)
s.Ctx = s.App.NewContext(false, tmtypes.Header{Height: 1, ChainID: "sei-test", Time: time.Now().UTC()})
s.Ctx = s.App.NewContext(false, sdk.Header{Height: 1, ChainID: "sei-test", Time: time.Now().UTC()})

Check warning

Code scanning / CodeQL

Calling the system time Warning test

Calling the system time may be a possible source of non-determinism
panic(err)
}
newHeader := tmtypes.Header{Height: oldHeight + 1, ChainID: oldHeader.ChainID, Time: time.Now().UTC()}
newHeader := sdk.Header{Height: oldHeight + 1, ChainID: oldHeader.ChainID, Time: time.Now().UTC()}

Check warning

Code scanning / CodeQL

Calling the system time Warning test

Calling the system time may be a possible source of non-determinism

Check warning

Code scanning / CodeQL

Calling the system time Warning test

Calling the system time may be a possible source of non-determinism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments