refactor(sei-db): encapsulate ReadOptions lifecycle in iterator constructors#2931
Open
pdrobnjak wants to merge 1 commit intopd/rocksdb-readopts-lifecyclefrom
Open
refactor(sei-db): encapsulate ReadOptions lifecycle in iterator constructors#2931pdrobnjak wants to merge 1 commit intopd/rocksdb-readopts-lifecyclefrom
pdrobnjak wants to merge 1 commit intopd/rocksdb-readopts-lifecyclefrom
Conversation
…ructors Push ReadOptions creation into the iterator constructors so callers never handle ReadOptions directly: - newIterator() creates a versioned iterator with internally managed ReadOptions, used by Iterator() and ReverseIterator() - newRangeIterator() creates a timestamp-range iterator, used by RawIterate() - Add Timestamp() method on the iterator wrapper so RawIterate can access per-entry timestamps without reaching into the raw source - Unexport the iterator constructor (NewRocksDBIterator -> buildIterator) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pd/rocksdb-readopts-lifecycle #2931 +/- ##
=================================================================
+ Coverage 57.34% 57.37% +0.02%
=================================================================
Files 2095 2095
Lines 172896 172900 +4
=================================================================
+ Hits 99145 99196 +51
+ Misses 64868 64823 -45
+ Partials 8883 8881 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2929.
Summary
ReadOptionscreation into the iterator constructors so callers never handleReadOptionsdirectlynewIterator()creates a versioned iterator with internally managedReadOptions, used byIterator()andReverseIterator()newRangeIterator()creates a timestamp-range iterator with internally managedReadOptions, used byRawIterate()Timestamp()method on the iterator wrapper soRawIteratecan access per-entry timestamps without reaching into the rawgrocksdb.IteratorNewRocksDBIterator->buildIterator)Test plan
🤖 Generated with Claude Code