Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2930 +/- ##
==========================================
- Coverage 57.34% 57.32% -0.03%
==========================================
Files 2095 2095
Lines 172872 172870 -2
==========================================
- Hits 99138 99101 -37
- Misses 64848 64879 +31
- Partials 8886 8890 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cody-littley
approved these changes
Feb 19, 2026
blindchaser
approved these changes
Feb 19, 2026
blindchaser
reviewed
Feb 19, 2026
| return newStore, nil | ||
| } | ||
|
|
||
| cs.cosmosCommitter = cosmosCommitter |
Contributor
There was a problem hiding this comment.
it looks before we always create new store and now we mutates self if it's non readOnly.
can you explain a bit why
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
The purpose of this PR is to make sure sei-chain will use the new CompositeSC which manages both MemIAVL and FlatKV backend:
Testing performed to validate your change