Skip to content

Use composite SC for RootMultistore#2930

Merged
yzang2019 merged 3 commits intomainfrom
yzang/use-compositesc-STO-360
Feb 19, 2026
Merged

Use composite SC for RootMultistore#2930
yzang2019 merged 3 commits intomainfrom
yzang/use-compositesc-STO-360

Conversation

@yzang2019
Copy link
Contributor

@yzang2019 yzang2019 commented Feb 19, 2026

Describe your changes and provide context

The purpose of this PR is to make sure sei-chain will use the new CompositeSC which manages both MemIAVL and FlatKV backend:

  • Root multistore (CMS) now creates composite sc instead of memiavl sc
  • Fixed a few functions for composite sc to make cosmos only mode behaves the same as before
  • Adjust flatkv LoadVersion interface to remove readonly

Testing performed to validate your change

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 19, 2026, 3:58 PM

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.32%. Comparing base (8e0d3be) to head (9175e8e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-db/state_db/sc/composite/store.go 68.75% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2930      +/-   ##
==========================================
- Coverage   57.34%   57.32%   -0.03%     
==========================================
  Files        2095     2095              
  Lines      172872   172870       -2     
==========================================
- Hits        99138    99101      -37     
- Misses      64848    64879      +31     
- Partials     8886     8890       +4     
Flag Coverage Δ
sei-chain 52.82% <73.68%> (-0.03%) ⬇️
sei-cosmos 48.18% <100.00%> (-0.01%) ⬇️
sei-db 68.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-cosmos/storev2/rootmulti/store.go 41.96% <100.00%> (ø)
sei-db/state_db/sc/flatkv/store.go 65.17% <100.00%> (+1.14%) ⬆️
sei-db/state_db/sc/composite/store.go 52.25% <68.75%> (+3.60%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* main:
  Removed unused voteInfos from App. (#2920)
  Add go bench for WAL (#2922)
return newStore, nil
}

cs.cosmosCommitter = cosmosCommitter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks before we always create new store and now we mutates self if it's non readOnly.

can you explain a bit why

@yzang2019 yzang2019 merged commit 7f57cdb into main Feb 19, 2026
54 of 57 checks passed
@yzang2019 yzang2019 deleted the yzang/use-compositesc-STO-360 branch February 19, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments