refactor: ♻️ match changes from t-squared and from root folder#287
Open
lwjohnst86 wants to merge 1 commit into
Open
refactor: ♻️ match changes from t-squared and from root folder#287lwjohnst86 wants to merge 1 commit into
lwjohnst86 wants to merge 1 commit into
Conversation
signekb
approved these changes
May 22, 2026
Member
signekb
left a comment
signekb
left a comment
There was a problem hiding this comment.
LGTM, only minor, minor things that should probably be changed in t-squared if you agree.
|
|
||
| links: | ||
| github: "https://github.com/{{ github_user }}/{{ github_repo }}" | ||
| # TODO: Confirm this is the correct URL |
Member
There was a problem hiding this comment.
Should this TODO be rephrased in t-squared to something like "# TODO: Add repo URL."?
| @@ -9,7 +9,7 @@ website: | |||
| site-url: "https://{{ github_user }}.github.io/{{ github_repo }}/" | |||
| {%- elif hosting_provider == "netlify" -%} | |||
| # TODO: Set the Netlify custom domain URL | |||
Member
There was a problem hiding this comment.
Could be aligned with other TODO phrasings and be "add" instead of "set"? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a bunch of small changes that match from t-squared and from the root (running
just sync-template-files).Needs a quick review.
Checklist
just run-all