Skip to content

fix: 🐛 make sure that sourced paths are available to subsequent build steps#466

Merged
lwjohnst86 merged 1 commit into
mainfrom
fix/persist-path-for-execs
May 19, 2026
Merged

fix: 🐛 make sure that sourced paths are available to subsequent build steps#466
lwjohnst86 merged 1 commit into
mainfrom
fix/persist-path-for-execs

Conversation

@joelostblom
Copy link
Copy Markdown
Contributor

@joelostblom joelostblom commented May 19, 2026

Description

For seedcase-project/seedcase-soil#43, I think the main issue is with the website build recipe, rather than the recent changes for soil. I believe that source will only put executables on path for the current shell, but each github action step runs in its own subshell. To persist executables across subshells, we would need to add them to path as per the docs. This should allow for format_output_for_docs() to find the seedcase executable when it is run in a later github action step.

Closes seedcase-project/seedcase-soil#43

This PR needs an in-depth review.


Note that I'm not 100% sure this is the fix because I'm unsure how to test it as I don't think I can trigger the Netlify build. Locally, you can reproduce by explicitly using a minimal path without seedcase-flower:

QUARTO="$(command -v quarto)"
env \
  QUARTO_PYTHON="$PWD/.venv/bin/python3" \
  PATH="/usr/bin:/bin" \
  "$QUARTO" render docs/guide/cli.qmd --execute

And "fix it" by instead running the following:

QUARTO="$(command -v quarto)"
env \
  QUARTO_PYTHON="$PWD/.venv/bin/python3" \
  PATH="$PWD/.venv/bin:/usr/bin:/bin" \
  "$QUARTO" render docs/guide/cli.qmd --execute

I moved my earlier general comment to #467

@lwjohnst86
Copy link
Copy Markdown
Member

Yea, I'm not sure this will work either but let's try 😋

@github-project-automation github-project-automation Bot moved this from In review to Approved in Platform development May 19, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Approved in Product development May 19, 2026
@lwjohnst86 lwjohnst86 merged commit 91dafe9 into main May 19, 2026
4 checks passed
@lwjohnst86 lwjohnst86 deleted the fix/persist-path-for-execs branch May 19, 2026 11:05
@github-project-automation github-project-automation Bot moved this from Approved to Done in Product development May 19, 2026
@github-project-automation github-project-automation Bot moved this from Approved to Done in Platform development May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

output_format_for_docs() not working in Quarto

2 participants