fix: 🐛 make sure that sourced paths are available to subsequent build steps#466
Merged
Conversation
Member
|
Yea, I'm not sure this will work either but let's try 😋 |
lwjohnst86
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For seedcase-project/seedcase-soil#43, I think the main issue is with the website build recipe, rather than the recent changes for soil. I believe that
sourcewill only put executables on path for the current shell, but each github action step runs in its own subshell. To persist executables across subshells, we would need to add them to path as per the docs. This should allow forformat_output_for_docs()to find the seedcase executable when it is run in a later github action step.Closes seedcase-project/seedcase-soil#43
This PR needs an in-depth review.
Note that I'm not 100% sure this is the fix because I'm unsure how to test it as I don't think I can trigger the Netlify build. Locally, you can reproduce by explicitly using a minimal path without
seedcase-flower:And "fix it" by instead running the following:
I moved my earlier general comment to #467