Add a script that launches a benchmark from a yaml file or a set of parameters#573
Open
R-Palazzo wants to merge 7 commits intoissue-532-define-yaml-filesfrom
Open
Add a script that launches a benchmark from a yaml file or a set of parameters#573R-Palazzo wants to merge 7 commits intoissue-532-define-yaml-filesfrom
R-Palazzo wants to merge 7 commits intoissue-532-define-yaml-filesfrom
Conversation
Contributor
R-Palazzo
force-pushed
the
issue-546-benchmark-generator
branch
from
fe78012 to
6913f4f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue-532-define-yaml-files #573 +/- ##
===============================================================
+ Coverage 82.91% 83.37% +0.45%
===============================================================
Files 38 39 +1
Lines 3301 3404 +103
===============================================================
+ Hits 2737 2838 +101
- Misses 564 566 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+19
to
+20
| parser.add_argument('--datasets', type=str, default=None) | ||
| parser.add_argument('--synthesizers', type=str, default=None) |
Member
There was a problem hiding this comment.
Should this be nargs instead of strings ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #546
CU-86b8h63t2