fix(cli): filter test callers in impact command#4
Merged
Conversation
CLI `cmd_impact` was counting test functions as production callers, inflating risk levels (e.g. `handle_message` showed HIGH with 33 callers when all were tests). Move `is_test_symbol` to `domain.rs` as shared utility and apply the same test/production separation logic used by the MCP `tool_impact_analysis`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd_impactwas counting test functions as production callers, inflating risk levels (e.g.handle_messageshowedRisk: HIGHwith 33 callers when all were tests, now correctly showsRisk: LOWwith 0 prod callers)is_test_symbolfromserver.rstodomain.rsas a shared utility so both MCP and CLI use the same test-filtering logic(N tests affected)separately, matching MCPtool_impact_analysisbehaviorTest plan
cargo test --release— all tests passcargo test --no-default-features— all tests passcargo run --release -- impact handle_messageshowsRisk: LOW, 0 prod callers, 33 tests affectedcargo run --release -- impact ensure_indexedshowsRisk: MEDIUM, 9 direct callers, 9 tests affected--json) includestests_affectedfield🤖 Generated with Claude Code