Fix flaky test_no_connection_refused_on_timeout#710
Draft
dkropachev wants to merge 1 commit intomasterfrom
Draft
Fix flaky test_no_connection_refused_on_timeout#710dkropachev wants to merge 1 commit intomasterfrom
dkropachev wants to merge 1 commit intomasterfrom
Conversation
dkropachev
force-pushed
the
fix-flaky-lwt-timeout-test
branch
from
1e12be2 to
f4f77a3
Compare
dkropachev
force-pushed
the
fix-flaky-lwt-timeout-test
branch
2 times, most recently
from
c1266b9 to
7417654
Compare
The test relies on LWT operations producing at least one timeout, but on fast CI runners all operations may complete before the default 10s timeout, causing `assert received_timeout` to fail. Fix by using a very short client-side request timeout (0.0001s) via an ExecutionProfile, which guarantees OperationTimedOut exceptions. Also add OperationTimedOut to the list of accepted timeout exception types so the test correctly recognizes client-side timeouts alongside server-side WriteTimeout/WriteFailure.
dkropachev
force-pushed
the
fix-flaky-lwt-timeout-test
branch
from
7417654 to
2d5edf7
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LightweightTransactionTests::test_no_connection_refused_on_timeoutthat fails when all LWT operations complete before the default timeout on fast CI runnersExecutionProfileto guaranteeOperationTimedOutexceptions occurOperationTimedOutto the list of accepted timeout exception types alongside server-sideWriteTimeout/WriteFailureTest plan