Skip to content

Conversation

@cyfung1031
Copy link
Collaborator

概述 Descriptions

变更内容 Changes

截图 Screenshots

@CodFrm
Copy link
Member

CodFrm commented Jan 23, 2026

咋单测还没过呢,没看明白修了什么问题,i18nDescription会返回 undefined ?

我觉得这个还好,在显示处,会显示undefined,也能提醒作者加上description

@cyfung1031
Copy link
Collaborator Author

咋单测还没过呢,没看明白修了什么问题,i18nDescription会返回 undefined ?

我觉得这个还好,在显示处,会显示undefined,也能提醒作者加上description

... 故意做一個坑給自己踩嗎
一般都是做fallback.. 不然類型不一致 (undefined vs string)

@CodFrm CodFrm merged commit 1c44b68 into scriptscat:main Jan 25, 2026
2 checks passed
@CodFrm
Copy link
Member

CodFrm commented Jan 25, 2026

咋单测还没过呢,没看明白修了什么问题,i18nDescription会返回 undefined ?
我觉得这个还好,在显示处,会显示undefined,也能提醒作者加上description

... 故意做一個坑給自己踩嗎 一般都是做fallback.. 不然類型不一致 (undefined vs string)

还好,无所谓了,类型不一致,但是类型准确,不同角度来说都有道理,不过对于这动态类型的语言无所谓了

@cyfung1031 cyfung1031 deleted the fix-f92d50ff413174c32e97022aa6bb851a5ea48a5f branch February 1, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants