ci: run build and test on pull requests#3574
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to run the existing lint/build/test pipeline for pull requests (including forks) and adds concurrency cancellation to reduce redundant runs.
Changes:
- Add a
pull_requesttrigger to.github/workflows/deploy.yml. - Add a workflow-level
concurrencygroup withcancel-in-progress: true.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cwillisf
force-pushed
the
ci/add-pr-trigger
branch
from
592dba9 to
d0d81b7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The deploy workflow only triggered on push and workflow_dispatch, so PRs (especially from forks) never got build or test feedback. Add a pull_request trigger and a concurrency group to cancel stale runs. Only cancel in-progress runs for pull_request events so that push- triggered release runs on develop are never interrupted.
cwillisf
force-pushed
the
ci/add-pr-trigger
branch
from
d0d81b7 to
f619fac
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolves
External PRs (e.g. #3571) only ran commitlint and the CLA assistant but never built or tested the code, even after a maintainer approved workflows to run.
Proposed Changes
pull_requesttrigger to thedeploy.ymlworkflow so lint, build, and test run on PRs (including from forks)cancel-in-progress: trueso re-pushes to a PR branch cancel stale runsReason for Changes
The
deploy.ymlworkflow only triggered onpushandworkflow_dispatch. Since fork pushes don't firepushevents on the base repo, external contributors got no build or test feedback on their PRs.Test Coverage
This PR itself serves as the test: the
build-scratch-blocksworkflow should now appear in the checks for this PR with lint and build-and-test jobs.semantic-releasewill dry-run safely on this non-release branch.