Fix HDR and Alpha issues in screenshots#7294
Open
MjnMixael wants to merge 1 commit intoscp-fs2open:masterfrom
Open
Fix HDR and Alpha issues in screenshots#7294MjnMixael wants to merge 1 commit intoscp-fs2open:masterfrom
MjnMixael wants to merge 1 commit intoscp-fs2open:masterfrom
Conversation
wookieejedi
added
fix
Member
|
I vote for this to be a point release canidate, but I'll defer to @BMagnu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7292
Fixes #7293
Clamp color values so we don't get undefined behavior from HDR colors in the png writer.
The opengl blend operations can affect the alpha channel in the framebuffer as a side effect so force the alpha channel to 255 before sending it to the png writer. I'm less inclined to mess with the blend function directly because it's unclear what, if anything, modifies the alpha channel intentionally and that has a much larger blast radius.