Skip to content

Modpack backend changes#136

Open
rhit-zhangl8 wants to merge 20 commits intofeat/modpacksfrom
install-grid
Open

Modpack backend changes#136
rhit-zhangl8 wants to merge 20 commits intofeat/modpacksfrom
install-grid

Conversation

@rhit-zhangl8
Copy link
Copy Markdown

Added install grid calculation for Windows, Windows server, and Linux server, as well as tests.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 50.90909% with 135 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.67%. Comparing base (25e7660) to head (b71a917).
⚠️ Report is 59 commits behind head on feat/modpacks.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
gql/resolver_modpacks.go 50.67% 97 Missing and 12 partials ⚠️
db/user.go 0.00% 11 Missing ⚠️
gql/directive.go 8.33% 11 Missing ⚠️
conversion/ent_to_graphql.go 82.60% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           feat/modpacks     #136      +/-   ##
=================================================
+ Coverage          41.18%   43.67%   +2.48%     
=================================================
  Files                135      113      -22     
  Lines               8274     6592    -1682     
=================================================
- Hits                3408     2879     -529     
+ Misses              4422     3257    -1165     
- Partials             444      456      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhit-mooretj
Copy link
Copy Markdown
Member

Do we think this would make sense to run on creation of a modpack release to store the values? Modpacks have target fields right now that are unused, and I wonder if upon a call of "createmodpackrelease" the resolver calls this function instead of it being outward facing for the frontend to run this over and over again. If so, we should remove the targets field ever being required for a SQL call to clean it up before we implement it on the frontend. What do you think Rob?

The code itself looks good to me, so I have no issues with that just maybe a slight tweak on the usecase in practice.

Copy link
Copy Markdown
Member

@budak7273 budak7273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, haven't made it all the way through yet

Comment thread util/ratelimits.go Outdated
@budak7273 budak7273 changed the title Install grid Modpack backend changes Apr 14, 2026
@budak7273
Copy link
Copy Markdown
Member

Do we think this would make sense to run on creation of a modpack release to store the values? <...>

I think we discussed this on the discord, is the comment's question still relevant? Since modpack releases are immutable I think it makes sense to cache the target support on them yeah.

@rhit-mooretj
Copy link
Copy Markdown
Member

Do we think this would make sense to run on creation of a modpack release to store the values? <...>

I think we discussed this on the discord, is the comment's question still relevant? Since modpack releases are immutable I think it makes sense to cache the target support on them yeah.

This is no longer relevant. Each release stores targets that are calculated upon previewing a release, and also stored on modpack creation. The query to get targets is through GetModpacks, as you'll get info on the releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants