Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/modpacks #136 +/- ##
=================================================
+ Coverage 41.18% 43.67% +2.48%
=================================================
Files 135 113 -22
Lines 8274 6592 -1682
=================================================
- Hits 3408 2879 -529
+ Misses 4422 3257 -1165
- Partials 444 456 +12 ☔ View full report in Codecov by Sentry. |
|
Do we think this would make sense to run on creation of a modpack release to store the values? Modpacks have target fields right now that are unused, and I wonder if upon a call of "createmodpackrelease" the resolver calls this function instead of it being outward facing for the frontend to run this over and over again. If so, we should remove the targets field ever being required for a SQL call to clean it up before we implement it on the frontend. What do you think Rob? The code itself looks good to me, so I have no issues with that just maybe a slight tweak on the usecase in practice. |
…ts on release creation, added query for calculating lockfile & targets. tests may fail due to schema change
… should be functional
…by running a test
budak7273
left a comment
There was a problem hiding this comment.
Partial review, haven't made it all the way through yet
I think we discussed this on the discord, is the comment's question still relevant? Since modpack releases are immutable I think it makes sense to cache the target support on them yeah. |
This is no longer relevant. Each release stores targets that are calculated upon previewing a release, and also stored on modpack creation. The query to get targets is through GetModpacks, as you'll get info on the releases |
Added install grid calculation for Windows, Windows server, and Linux server, as well as tests.