[dev] Hide Hashie Mash key-conflict warnings#2330
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2330 +/- ##
========================================
Coverage 84.98% 84.99%
========================================
Files 504 504
Lines 20668 20668
Branches 377 377
========================================
+ Hits 17565 17566 +1
+ Misses 3100 3099 -1
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenTopping
left a comment
There was a problem hiding this comment.
Looks like we are only using Hashie::Mash here. Wondering if there is a replacement for it in vanilla ruby / rails and we can remove it entirely?
That would be lovely. Unfortunately there doesn't seem to be a drop-in replacement, but I think we should be using strongly-typed config, rather than a very lenient hash structure. https://dry-rb.org/gems/dry-struct/1.6/ looks like a promising direction to go, unless there is something more Railsy. |
|
Given that progress on related issues and fixes appears stalled, would muting the warnings as specifically as possible (as in this PR) seems like a workable solution for now? |
BenTopping
left a comment
There was a problem hiding this comment.
I think this is fine as a temporary solution. It would be useful to add a TODO / comment about why we are dong it.
Thanks, comment added in |
Reduces log length and developer frustration.
Changes proposed in this pull request
Implements: https://www.rubydoc.info/gems/hashie/Hashie%2FMash.quiet
min,max,size,classin developer logs.Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version