Conversation
…iable for DB_PASSWORD
…ate bootstrap script
Threated
left a comment
Threated
left a comment
There was a problem hiding this comment.
Drop the second commit and you need to update the justfile which calls bootstrap to have the new IMAGE var instead of TAG in one place.
| docker_config=~/.docker/config.json | ||
| docker_config_mount="" | ||
| [ -f "$docker_config" ] && docker_config_mount="-v $docker_config:/root/.docker/config.json:ro" | ||
| docker run --rm \ | ||
| -v {{ config_dir }}:{{ config_dir }} \ | ||
| -v /var/run/docker.sock:/var/run/docker.sock \ | ||
| $docker_config_mount \ |
There was a problem hiding this comment.
Hmm not super happy about that. In 99% of cases we pull public images anyways and this workaround is only because of podman as well right? Is there any reason to not make the podest2fhir image at least public already?
There was a problem hiding this comment.
VM is using Docker now (docker compose uses an API that podman compatibility mode does not support yet containers/podman#17726). This workaround is also needed and works for Docker.
There was a problem hiding this comment.
Hmm sad but ok. Can you add a comment explaining why we need it and when we might not anymore? After that I will merge it
|
Maybe we should consider keeping the second commit? Our CI would push feature branch images only to GHCR and this would make testing them possible especially with the new |
|
Oh I see but will this work with the version tag push logic? I guess it's fine than |
|
Yes, releases will land on Docker Hub |
…rivate registries
2 participants
No description provided.