Retrieve binary releases from github instead of bintray#290
Retrieve binary releases from github instead of bintray#290myii merged 2 commits intosaltstack-formulas:masterfrom
Conversation
00302f2 to
d434e25
Compare
|
There is a chicken and egg problem with the tests. The tests for this pull request were failing due to the issue fixed with pull request #288. The tests of pull request #288 were failing due to the problems fixed by this pull request. Therefore I've pulled in the commit made by @Lucianovici to see if the tests succeed with the fixes of both of the pull requests. I can remove the commit again if it is cleaner to merge both pull requests separately. |
|
Please also check saltstack-formulas/postgres-formula#311 (review) |
|
Thanks for pointing out the other issues. I agree, it seems better to wait for a response from Salt devs before including the fix for the 'imports'. I'll remove that commit from this pull request again, since we already have #288 for that. For the record, the tests succeeded with the commit from #288: |
f808d55 to
d434e25
Compare
noelmcloughlin
left a comment
There was a problem hiding this comment.
LGTM, thanks @danny-smit
|
🎉 This PR is included in version 2.0.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Thanks @danny-smit, merging this based on that outcome. With the actual testing being here in GitHub Actions, the failures won't prevent Appreciate the review, @noelmcloughlin. |
Various discussions about the underlying issue: * saltstack/salt#60188 * saltstack-formulas/postgres-formula#311 * saltstack-formulas/docker-formula#290
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
#281
Describe the changes you're proposing
Replace URLs to bintray.com with URLs to github.com to retrieve binary releases.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context