Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native read/write functions for PCI were ignoring
region.base, which I think is wrong. This PR changes that. The CI script will fail on this PR until #279 is merged as I've added a bunch of tests forOperationRegionthat rely on the corrected_BBNname.@IsaacWoods: I know I've added a bunch of PRs and issues recently. I'm not meaning to put you under any pressure for any kind of quick response, I just have a bit of spare time this week to play with the crate and see if I can get it running with no errors on my hardware. Hopefully it's helpful!