Open
Conversation
CathalMullan
force-pushed
the
graviola-tests
branch
2 times, most recently
from
fe82b78 to
6b54626
Compare
CathalMullan
force-pushed
the
graviola-tests
branch
2 times, most recently
from
13190d1 to
40ea033
Compare
CathalMullan
force-pushed
the
graviola-tests
branch
from
40ea033 to
914eb80
Compare
Contributor
Author
|
Opted to patch out crabgrind to avoid needing valgrind in CI. |
bjorn3
reviewed
Mar 11, 2026
| serde_json = "1" | ||
| - | ||
| -[target.'cfg(all(target_os = "linux", target_arch = "x86_64"))'.dev-dependencies] | ||
| -crabgrind = "=0.1.9" # compatible with valgrind package on GHA ubuntu-latest |
Member
There was a problem hiding this comment.
Do you think upstream would accept putting crabgrind behind a default-on feature? And doing the aws-lc-rs update upstream? That would reduce the maintenance burden of keeping this patch up to date.
Contributor
Author
There was a problem hiding this comment.
I imagine they'd be fine with moving it behind a feature, I'll reach out and see.
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as a draft for now, since none of these jobs will actually pass:
x86_64 needs the rustc fixvalgrind is needed due to crabgrind usage: https://github.com/ctz/graviola/blob/v/0.3.2/graviola/src/low/ct.rs#L5
Could consider patching it out, or making it optional upstream.