Turn old edition lint (anonymous-parameters) into warn-by-default on 2015#82918
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 13, 2021
Merged
Turn old edition lint (anonymous-parameters) into warn-by-default on 2015#82918bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
anonymous_parametersandwarn-by-default on the 2015 edition. I would also like to do this forkeyword_identsabsolute_paths_not_starting_with_crate, but I feel that case is slightly less clear-cut.Note that this only affects code on the 2015 edition, such code is illegal in future editions anyway.
This was spurred by dtolnay/syn#972: old edition syntax breaks tooling (like syn), and while the tooling should be free to find its balance on how much to support prior editions, it does seem like we should be nudging such code towards the newer edition, and we can do that by turning this Allow lint into a Warn.
In general, I feel like migration lints from an old edition should be made Warn after a year or so, and idiom lints for the new edition should be made Warn after a couple months.
cc @m-ou-se, this is for stuff from the 2015-2018 migration but you might be interested.