Improve errors about #[deprecated] attribute#78626
Merged
bors merged 5 commits intorust-lang:masterfrom Nov 3, 2020
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
#[deprecated]on a trait impl block into an error, which fixes Deprecation attribute on trait impl block is accepted but has no effect #78625;#[deprecated]to use the span of the attribute instead of the item; and--cap-lintsand doesn't break any existing dependencies.Can be reviewed per commit.
Example:
Before:
After: