revert #75443, update mir validator#78410
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 8, 2020
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #75443 to fix #75992 and instead uses #75419 to fix #75313.
Adapts #75419 to correctly deal with unevaluated constants as otherwise some
feature(const_evaluatable_checked)tests would ICE.Note that #72793 was also fixed by #75443, but as that issue only concerns
feature(type_alias_impl_trait)I deleted that test case for now and would reopen that issue.#75443 may have also allowed some other code to now successfully compile which would make this revert a breaking change after 2 stable versions, but I hope that this is a purely theoretical concern.
See https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/generator.20upvars/near/214617274 for more reasoning about this.
r? @nikomatsakis @eddyb @RalfJung