Separate private_intra_doc_links and broken_intra_doc_links into separate lints#77249
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 27, 2020
Merged
Separate private_intra_doc_links and broken_intra_doc_links into separate lints#77249bors merged 2 commits intorust-lang:masterfrom
private_intra_doc_links and broken_intra_doc_links into separate lints#77249bors merged 2 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not ideal because it means
deny(broken_intra_doc_links)willno longer
deny(private_intra_doc_links). However, it can't be fixedwith a new lint group, because
brokenis already in therustdoclintgroup; there would need to be a way to nest groups somehow.
This also removes the early
returnso that the link will be generatedeven though it gives a warning.
r? @Manishearth
cc @ecstatic-morse (#77242 (comment))