WIP Add MIR argument for #[track_caller] (RFC 2091 3/N)#65258
Closed
anp wants to merge 6 commits intorust-lang:masterfrom
Closed
WIP Add MIR argument for #[track_caller] (RFC 2091 3/N)#65258anp wants to merge 6 commits intorust-lang:masterfrom
anp wants to merge 6 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making this work requires making
core::panic::Locationa lang item, which is the first commit on this branch (prior are from the depended-on PR).Depends on: #65182
Tracking issue: #47809
RFC text
TODO:
#[track_caller]in rustc_mir::build (reference existing implicit arguments work if needed)ty::Instance::fn_sigto contain the new typenote to self: check on by-val vs. by-ref for this argused &'static per @eddybReifyShim(see other shims for generating things in shims, ask @eddyb if fighting consteval)ty::Instance::resolve#[track_caller]s pass the same callsite#[track_caller]s pass distinct callsites