[STABLE] library: wasm32-wasip1-threads has functional pthreads#153634
Open
jieyouxu wants to merge 1 commit intorust-lang:stablefrom
Open
[STABLE] library: wasm32-wasip1-threads has functional pthreads#153634jieyouxu wants to merge 1 commit intorust-lang:stablefrom
wasm32-wasip1-threads has functional pthreads#153634jieyouxu wants to merge 1 commit intorust-lang:stablefrom
Conversation
Minimal backport-suitable fix to avoid returning `UNSUPPORTED_PLATFORM` for `wasm32-wasip1-threads` which has a working pthreads implementation via `emnapi`. The stable regression was reported in <rust-lang#153475>.
rustbot
added
S-waiting-on-author
Member
Author
|
@alexcrichton is this what you had in mind in #153475 (comment)? |
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Member
|
Indeed! I believe this would fix the issue while being less risky than backporting #152183 |
rustbot
added
S-waiting-on-review
Collaborator
|
Member
Author
rustbot
added
the
stable-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal backport-suitable fix to avoid returning
UNSUPPORTED_PLATFORMforwasm32-wasip1-threadswhich has a working pthreads implementation viaemnapi.The stable regression was reported in #153475.
This PR should be stable-backported-only (if accepted by T-libs) to mitigate #153475 on stable with a stable point release.