rustdoc: don't give depreciation notes special handling#149931
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 10, 2026
Merged
rustdoc: don't give depreciation notes special handling#149931rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
the
S-waiting-on-review
rustbot
added
T-rustdoc
Contributor
|
Gonna let Guillaume r+, but looks good to me! |
This comment has been minimized.
This comment has been minimized.
Member
|
Just commented about this here. I'd personally just make the update without gating it behind next edition but seems like something worth discussing with the rest of the team. |
Collaborator
|
☔ The latest upstream changes (presumably #150645) made this pull request unmergeable. Please resolve the merge conflicts. |
1 similar comment
Contributor
|
☔ The latest upstream changes (presumably #150645) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
This was discussed in this month's t-rustdoc meeting, the consensus was the edition gating should be removed and the "future edition" behavior should apply to all editions. |
lolbinarycat
changed the title
lolbinarycat
force-pushed
the
rustdoc-depr-html-future
branch
from
fdb1d6e to
88d9df0
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
rustdoc-depr-html-future
branch
from
88d9df0 to
438b126
Compare
GuillaumeGomez
approved these changes
Mar 9, 2026
Member
|
Thanks! @bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 9, 2026
…ure, r=GuillaumeGomez rustdoc: don't give depreciation notes special handling based on discussion in rust-lang#149741 we're currently using pre-wrap here which forces us to do a bunch of other hacky weird stuff, but getting rid of all that would likely break some existing docs, so i'm proposing we do it across an edition. r? @GuillaumeGomez
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Rollup of 8 pull requests Successful merges: - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.) - #149931 (rustdoc: don't give depreciation notes special handling) - #153608 (ast_passes: unsupported arch w/ scalable vectors) - #153609 (Add missing `Diag::with_span_suggestion_with_style` method) - #153610 (Only lint unused features if they are unstable) - #153616 (Update `sysinfo` version to `0.38.4`) - #153619 (Update books) - #153624 (Ping fmease on parser modifications)
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Rollup of 7 pull requests Successful merges: - #149931 (rustdoc: don't give depreciation notes special handling) - #153608 (ast_passes: unsupported arch w/ scalable vectors) - #153609 (Add missing `Diag::with_span_suggestion_with_style` method) - #153610 (Only lint unused features if they are unstable) - #153616 (Update `sysinfo` version to `0.38.4`) - #153619 (Update books) - #153624 (Ping fmease on parser modifications)
lolbinarycat
added
the
relnotes
rust-timer
added a commit
that referenced
this pull request
Mar 10, 2026
Rollup merge of #149931 - lolbinarycat:rustdoc-depr-html-future, r=GuillaumeGomez rustdoc: don't give depreciation notes special handling based on discussion in #149741 we're currently using pre-wrap here which forces us to do a bunch of other hacky weird stuff, but getting rid of all that would likely break some existing docs, so i'm proposing we do it across an edition. r? @GuillaumeGomez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on discussion in #149741
we're currently using pre-wrap here which forces us to do a bunch of other hacky weird stuff, but getting rid of all that would likely break some existing docs, so i'm proposing we do it across an edition.
r? @GuillaumeGomez