feat: offer on is_some_and for replace_is_method_with_if_let_method#21623
Merged
ShoyuVanilla merged 1 commit intorust-lang:masterfrom Feb 18, 2026
Merged
feat: offer on is_some_and for replace_is_method_with_if_let_method#21623ShoyuVanilla merged 1 commit intorust-lang:masterfrom
ShoyuVanilla merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
force-pushed
the
replace-is-some-and
branch
2 times, most recently
from
d0b4f12 to
3931f9e
Compare
Example
---
```rust
fn main() {
let x = Some(1);
if x.is_som$0e_and(|it| it != 3) {}
}
```
**Before this PR**
Assist not applicable
**After this PR**
```rust
fn main() {
let x = Some(1);
if let Some(it) = x && it != 3 {}
}
```
A4-Tacks
force-pushed
the
replace-is-some-and
branch
from
3931f9e to
63126cc
Compare
ShoyuVanilla
approved these changes
Feb 18, 2026
rustbot
removed
the
S-waiting-on-review
Contributor
|
Looks like the predicate gets dropped when the argument is not a closure |
Member
Author
|
Okay, fixes in #21787 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
Assist not applicable
After this PR