Implement pull-up and pull-down bias flags#84
Open
jothan wants to merge 3 commits intorust-embedded:masterfrom
Open
Implement pull-up and pull-down bias flags#84jothan wants to merge 3 commits intorust-embedded:masterfrom
jothan wants to merge 3 commits intorust-embedded:masterfrom
Conversation
jothan
force-pushed
the
master
branch
3 times, most recently
from
659e37a to
4a1cad3
Compare
eldruin
reviewed
Jul 3, 2025
Member
eldruin
left a comment
eldruin
left a comment
There was a problem hiding this comment.
Sounds good to me, thanks!
Could you rebase this to the current master and add an entry to the changelog about it?
Contributor
Author
There you go, done ! |
grahamc
reviewed
Oct 19, 2025
|
|
||
| // True if the line is marked as having a pull-up bias | ||
| pub fn is_bias_pull_up(&self) -> bool { | ||
| self.flags.contains(LineFlags::BIAS_PULL_UP) |
There was a problem hiding this comment.
Would this be more correct if you compared based on self.bias() ? I'm curious because bias seems to indicate multiple flags could be set, implying no bias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty simple and self descriptive.