ci: update cargo-rbmt and adopt toolchain mgmt#80
Merged
tcharding merged 4 commits intorust-bitcoin:masterfrom Mar 18, 2026
Merged
ci: update cargo-rbmt and adopt toolchain mgmt#80tcharding merged 4 commits intorust-bitcoin:masterfrom
tcharding merged 4 commits intorust-bitcoin:masterfrom
Conversation
9f31b67 to
c10fdec
Compare
Collaborator
Author
|
@tcharding just a heads up, need this to unblock CI here. On the plus side, the new cargo-rbmt random feature tests found a little bug. |
Collaborator
Author
|
If we wanna get a little tricky in the action, could compress a bunch of the job defintions down: Check:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
command: [lint, api, docs, docsrs, integration]
steps:
- uses: actions/checkout@v6
- uses: rust-bitcoin/rust-bitcoin-maintainer-tools/.github/actions/setup-rbmt@18e7f1788abfc14f5fb76204a3deab43b03ba39c
- name: "Run ${{ matrix.command }}"
run: cargo rbmt ${{ matrix.command }}EDIT: couldn't help it, gave it a shot. |
tcharding
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI job was using a floating version of the cargo-rbmt install action (e.g.
setup-rbmt@master) and the tool is still way too unstable for that, causing CI to die. Bumping the version and pinning it here.This new version of cargo-rbmt includes the toolchain management, so the justfile and CI job have been simplified. It also has the new spot for the API files which doesn't include the package name.
The new version of cargo-rbmt also includes the random subset of features to test feature, which I believe exposed an issue in the v2 code (addressed in the first commit).