Handled additional Range constructor in toSigners side condition.#944
Draft
mariaKt wants to merge 1 commit intofeature/p-tokenfrom
Draft
Handled additional Range constructor in toSigners side condition.#944mariaKt wants to merge 1 commit intofeature/p-tokenfrom
mariaKt wants to merge 1 commit intofeature/p-tokenfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
allKeyscondition in the requires clause oftoSignerswith another function,allRangeWrappedKeys, that works in exactly the same way except is unwraps an additional Range constructor from the providedListItem. ThisRangeis generated fromfromKey, and the existingallKeysimplementation was not sufficient to handle it, as it was expecting just a List.The issue came up when investigating the failure of the proof for test_process_initialize_multisig2. I attach a file that contains a part of the stuck configuration, where I isolated a term that shows the issue. The relevant term is
SignersError(...). With this change, the proof was able to pass.signers-error.txt
Note: I chose to use a new function rather than extend the functionality of
allKeysbeyond its (apparent) intend to handle Lists, but I believe that the issue could be solved with just another rule inallKeys, if that is what you prefer.