feat: add BUCKET_PREFIX support for S3 uploads#191
Open
jpswelch wants to merge 1 commit intorunpod-workers:mainfrom
Open
feat: add BUCKET_PREFIX support for S3 uploads#191jpswelch wants to merge 1 commit intorunpod-workers:mainfrom
jpswelch wants to merge 1 commit intorunpod-workers:mainfrom
Conversation
- Add BUCKET_PREFIX environment variable to organize uploaded files under a custom prefix/folder path in S3 - When BUCKET_PREFIX is set, uses upload_file_to_bucket with prefix (preserves original filename) - When BUCKET_PREFIX is not set, uses upload_image for backward compatibility (random UUID filename) - Leading/trailing slashes are automatically stripped from BUCKET_PREFIX - Update configuration documentation with the new environment variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for
BUCKET_PREFIXenvironment variable to allow organizing S3 uploaded files under a custom prefix/folder path.BUCKET_PREFIXis set: usesupload_file_to_bucketwith the prefix (e.g.,outputs/comfyui/{job_id}/filename.png)BUCKET_PREFIXis not set: uses originalupload_imagefor backward compatibilityIssues closed