Add pagination for wishlist_items. #141#151
Add pagination for wishlist_items. #141#151nenadmil wants to merge 2 commits intorubyforgood:masterfrom
Conversation
leesharma
left a comment
leesharma
left a comment
There was a problem hiding this comment.
Thank you for the PR! 🎉
Note: I set this up as a review app with 50 corgis: review app
The code looks good, but I've got a few bugs/change requests before merging:
-
Bug - On the wishlist page, it looks like all 50 items are shown (not just the first 10), despite the pagination links being at the bottom.
-
Request - The pagination links appear on the page, but they're not styled. Could you add the appropriate Bootstrap styles?
Current view:
-
Request - This is a small one! Since the partials are so big, could you please change the default page size to 5?
Again, thank you for the PR! Let me know if you have any questions about my review comments!
| @@ -0,0 +1,12 @@ | |||
| # frozen_string_literal: true | |||
| Kaminari.configure do |config| | |||
| config.default_per_page = 10 | |||
There was a problem hiding this comment.
The config looks good!
Since our wishlist item partials are so large, could you please set the default to 5?
|
Hi, I fixed all, but there is a known problem with bullet that pops-up: Regards, |
3 participants
Resolves #141
Add pagination for wishlist_items using kaminari gem.