Request Item → Item Request #5196
Open
+74
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwaiid
commented
May 11, 2025
awwaiid
commented
May 11, 2025
awwaiid
commented
May 11, 2025
awwaiid
commented
May 11, 2025
awwaiid
commented
May 11, 2025
awwaiid
commented
May 11, 2025
dorner
requested changes
May 15, 2025
Collaborator
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
Minor suggestion, otherwise looks good. 🎉
app/views/requests_confirmation_mailer/confirmation_email.html.erb
Outdated
Show resolved
Hide resolved
3 tasks
dorner
requested changes
Aug 15, 2025
| def name_with_unit(quantity_override = nil) | ||
| if Flipper.enabled?(:enable_packs) && request_unit.present? | ||
| "#{item&.name || name} - #{request_unit.pluralize(quantity_override || quantity.to_i)}" | ||
| "#{item_name} - #{request_unit.pluralize(quantity_override || quantity.to_i)}" |
Collaborator
There was a problem hiding this comment.
I think you forgot to use the new method here? :)
Collaborator
Author
There was a problem hiding this comment.
This is one of the display helpers:
- ItemRequest#item_name gives the item's name and falls back to the local copy
- ItemRequest#quantity_with_units shows the qty and units but not the name
- ItemRequest#name_with_unit shows the name and the unit but not qty
Collaborator
Collaborator
|
@janeewheatley @awwaiid yep, my most recent comments have not been addressed. |
Collaborator
Author
|
@dorner mmmm I think the one you mentioned shouldn't or can't use the other display helper (and this is a different display helper). Eh? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at removing
request_itemeverywhere.