Skip to content

Improvements to specs of Hash.[] #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eregon merged 2 commits into from
Jan 18, 2026
Merged

Improvements to specs of Hash.[] #1328

eregon merged 2 commits into from
Jan 18, 2026
+9 −9

Conversation

@herwinw
Copy link
Member

@herwinw herwinw commented Jan 18, 2026

  • Remove checks from inside the blocks that raise. This is all code that was never executed
  • Add message validations for exceptions

@herwinw
Small improvoments to specs of Hash.[]
67b74b4 
* Remove all validations inside a block that should raise, this code
  should never be executed.
* Update the spec with `[:nil]`, to use `[nil]` instead. The old code
  tested the exact same thing as `[:a]` above it.
@herwinw
Include message validation in expected exception of Hash.[]
a3b0974
@eregon eregon merged commit fd1e5fd into ruby:master Jan 18, 2026
16 checks passed
@herwinw herwinw deleted the hash_constructor branch January 18, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eregon eregon eregon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@herwinw @eregon