Closed
Conversation
Member
Author
|
@peterzhu2118 and @st0012: I see that there are many failing checks. I'd like to wait for opinions about the test code before addressing the failures (If no one likes this PR, it needs to be closed, not fixed.) |
Member
Author
|
@st0012 and @peterzhu2118: The checks now all pass, so I think this is ready for review. |
st0012
reviewed
Oct 4, 2025
Member
st0012
left a comment
There was a problem hiding this comment.
By end to end, I do mean running rdoc executable directly in tests 👍
But if we do that, we probably don't need most or all the helpers and stuff from XrefTestCase. Instead, we can create a new IntegrationTestCase that provides the run_rdoc method directly.
Member
Author
|
To be replaced by #1430. |
Member
Author
|
Revised and moved to PR 1430. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there's been some discussion about end-to-end testing. Here's a start.
There are two questions: