Fix String#append_as_bytes to accept Integer #2817
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
requested changes
Jan 21, 2026
Member
soutaro
left a comment
soutaro
left a comment
There was a problem hiding this comment.
Thank you for opening this PR! Two requests:
- Looks like the method accepts multiple arguments. So, can you support it?
(*String | Integer) -> Stringwould be its type. - Can you update test in
String_test.rb? It already has a test case, so adding a few assertions withIntegershould be fine.
bdewater-thatch
force-pushed
the
bdewater-thatch-patch-1
branch
from
430ec7e to
2a5533d
Compare
Contributor
Author
|
Thanks! I'm new to RBS, appreciate the pointers :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rdoc example a few lines above the diff, this is valid too.
rbs/core/string.rbs
Lines 1620 to 1622 in 5771976