Skip to content

Adapt ParametersNode#signature to ErrorRecoveryNode #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eregon merged 1 commit into from
Apr 5, 2026
+8 −4
Merged

Adapt ParametersNode#signature to ErrorRecoveryNode #4064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/prism/node_ext.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,10 +329,7 @@ def signature
case param
when MultiTargetNode
names << [:req]
when NoKeywordsParameterNode, KeywordRestParameterNode,
NoBlockParameterNode, BlockParameterNode,
ForwardingParameterNode
# Invalid syntax, e.g. "def f(**nil, ...)" moves the NoKeywordsParameterNode to posts
when ErrorRecoveryNode
raise "Invalid syntax"
else
names << [:req, param.name]
Expand Down
7 changes: 7 additions & 0 deletions test/prism/ruby/parameters_signature_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@ def test_forwarding
assert_parameters([[:rest, :*], [:keyrest, :**], [:block, :&]], "...")
end

def test_invalid_syntax
e = assert_raise(RuntimeError) do
Prism.parse_statement("def f(**nil, ...); end").parameters.signature
end
assert_equal("Invalid syntax", e.message)
end

private

def assert_parameters(expected, source, compare: true)
Expand Down