Skip to content

RB_GC_GUARD() the VALUE for RSTRING_PTR() to ensure the char* does not move #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eregon wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

RB_GC_GUARD() the VALUE for RSTRING_PTR() to ensure the char* does not move #3892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ext/prism/extension.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,16 @@ build_options_i(VALUE key, VALUE value, VALUE argument) {
const char *version = check_string(value);

if (RSTRING_LEN(value) == 7 && strncmp(version, "current", 7) == 0) {
const char *ruby_version = RSTRING_PTR(rb_const_get(rb_cObject, rb_intern("RUBY_VERSION")));
VALUE ruby_version_string = rb_const_get(rb_cObject, rb_intern("RUBY_VERSION"));
const char *ruby_version = RSTRING_PTR(ruby_version_string);
if (!pm_options_version_set(options, ruby_version, 3)) {
rb_exc_raise(rb_exc_new_cstr(rb_cPrismCurrentVersionError, ruby_version));
rb_exc_raise(rb_exc_new_str(rb_cPrismCurrentVersionError, ruby_version_string));
}

RB_GC_GUARD(ruby_version_string); // Do not move ruby_version while running the code above
} else if (RSTRING_LEN(value) == 7 && strncmp(version, "nearest", 7) == 0) {
const char *ruby_version = RSTRING_PTR(rb_const_get(rb_cObject, rb_intern("RUBY_VERSION")));
VALUE ruby_version_string = rb_const_get(rb_cObject, rb_intern("RUBY_VERSION"));
const char *ruby_version = RSTRING_PTR(ruby_version_string);
const char *nearest_version;

if (ruby_version[0] < '3' || (ruby_version[0] == '3' && ruby_version[2] < '3')) {
Expand All @@ -220,6 +224,8 @@ build_options_i(VALUE key, VALUE value, VALUE argument) {
if (!pm_options_version_set(options, nearest_version, 3)) {
rb_raise(rb_eArgError, "invalid nearest version: %s", nearest_version);
}

RB_GC_GUARD(ruby_version_string); // Do not move ruby_version while running the code above
} else if (!pm_options_version_set(options, version, RSTRING_LEN(value))) {
rb_raise(rb_eArgError, "invalid version: %" PRIsVALUE, value);
}
Expand Down