Handle String-like objects for Ripper.sexp #3891
Open
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eregon
commented
Jan 29, 2026
eregon
commented
- RSpec relies on this in https://github.com/rspec/rspec/blob/rspec-support-v3.13.6/rspec-support/lib/rspec/support/source.rb#L57 which is given an RSpec::Support::EncodedString.
- CI failure caused by this on truffleruby: https://github.com/sporkmonger/addressable/actions/runs/21457707372/job/61802608154#step:7:14
* RSpec relies on this in https://github.com/rspec/rspec/blob/rspec-support-v3.13.6/rspec-support/lib/rspec/support/source.rb#L57 which is given an RSpec::Support::EncodedString. * CI failure caused by this on truffleruby: https://github.com/sporkmonger/addressable/actions/runs/21457707372/job/61802608154#step:7:14
eregon
force-pushed
the
ripper-sexp-coerce
branch
from
5bbfbcf to
6e1d9e9
Compare
Earlopain
reviewed
Jan 29, 2026
Collaborator
Earlopain
left a comment
Earlopain
left a comment
There was a problem hiding this comment.
It looks like the rules are a bit more complex: https://github.com/ruby/ruby/blob/acc414572c213f2690eee56bac3d2355a24e5930/ext/ripper/ripper_init.c.tmpl#L357-L376
Do you want to implement those also? File should be easy at least.
| def test_sexp_coercion | ||
| string_like = Object.new | ||
| def string_like.to_str; "a"; end | ||
| assert_equal [:program, [[:vcall, [:@ident, "a", [1, 0]]]]], Translation::Ripper.sexp(string_like) |
Collaborator
There was a problem hiding this comment.
Doesn't really matter what the result is, we just want the same behaviour as native
Suggested change
| assert_equal [:program, [[:vcall, [:@ident, "a", [1, 0]]]]], Translation::Ripper.sexp(string_like) | |
| assert_equal Ripper.sexp(string_like), Translation::Ripper.sexp(string_like) |
Member
Author
I see. If you want to do it feel free to push to this branch, otherwise I can get to it tomorrow or so. |
Collaborator
|
Tomorrow is fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.