Merged
Conversation
361ce27 to
30b69a8
Compare
Contributor
Author
|
@ko1, please let me know if you would like me to change the name of the configuration! |
Both `up` and `down` only show 1 source line when called, I think it would be more useful if there was a configurable way to provide more context. This adds a `show_src_lines_frame` configuration option (which defaults to `1`) that determines how many source lines get shown for frame operations `up`, `down`, and `set` (frame).
30b69a8 to
d3d3dd4
Compare
Contributor
Author
|
Closes #1135. |
Collaborator
|
Thank you! |
This was referenced Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the feedback from #1094 and resolves #1135.
Description
Both
upanddownonly show 1 source line when called, I think it would be more useful if there was a configurable way to provide more context.This adds a
show_src_lines_frame(happy to rename this) configuration option (which defaults to1) that determines how many source lines get shown for frame operationsup,down, andset(frame).I think the
lib/debug/config.rbchanges are easier to review without whitespace:Also probably useful to note that
byebugdisplays more lines by default making it quite a difference switching from byebug to debug:byebug-vs-debug.mov