Support for adding annotations to deployments in Connect#794
Support for adding annotations to deployments in Connect#794SamEdwardes merged 4 commits intomainfrom
Conversation
lucasrod16
left a comment
There was a problem hiding this comment.
This makes sense to me given the use case described in #793. Could you add a couple of helm unit tests to help prevent regressions? These cases should cover it:
- No annotations on the deployment by default
- Annotations are applied when
deployment.annotationsis set
Here are some test cases for the chronicle chart for reference:
helm/charts/posit-chronicle/tests/metadata_test.yaml
Lines 68 to 80 in 87ae10f
There was a problem hiding this comment.
My editor auto-formatted on save, which caused the unintentional changes to older versions. These are purely formatting fixes, the only functional change is the new line added for 0.8.31.
|
Thank you @lucasrod16. I added some unit tests. They are passing. Please let me know if you have any other comments, or if the PR is ready to merge. |
lucasrod16
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this @SamEdwardes!
Allows users to add custom annotations to the rstudio-pm Deployment resource metadata, matching the pattern added to Connect in PR #794.
Allow users to set custom annotations on the Workbench Deployment resource via deployment.annotations, matching the existing Connect chart behavior from PR #794.
Closes #793
Hey Posit Connect team, could you please review this PR. Details on the use case or in the issue mentioned above.
I deployed Connect using this chart and verified that the annotations correctly get set on the deployment: