Add optional containerProps, mainProps and drawerProps props#357
Open
SuhairZain wants to merge 1 commit intoroot-two:masterfrom
Open
Add optional containerProps, mainProps and drawerProps props#357SuhairZain wants to merge 1 commit intoroot-two:masterfrom
SuhairZain wants to merge 1 commit intoroot-two:masterfrom
Conversation
Author
|
@rt2zz Hi, would you be able to look into this PR? This is a non-breaking change. |
Author
|
@mmazzarolo Would you be able to look at this? |
Contributor
|
@SuhairZain did you ping me by mistake? 🤔 |
Author
|
@mmazzarolo My bad. Didn't mean to tag you. Sorry. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be helpful to allow a great amount of customization. Would also help a lot in making the components accessible (the user can decide which component to have which accessibility prop etc).