Skip to content

Skip megapools with no active validators when calculating ETH Rewards #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomaspanf merged 3 commits into from
Feb 16, 2026
+12 −5
Merged

Skip megapools with no active validators when calculating ETH Rewards #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5293b4
Skip megapools with no active validators when calculating ETH Rewards
thomaspanf Feb 16, 2026
d57ba32
Guard against zero division when getting the megapool bond
thomaspanf Feb 16, 2026
561f07f
Scope network values and megapool bond per megapool instead of per va…
thomaspanf Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bindings/utils/state/megapool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ type NativeMegapoolDetails struct {
// Get the normalized bond per 32 eth validator
// This is used in treegen to calculate attestation scores
func (m *NativeMegapoolDetails) GetMegapoolBondNormalized() *big.Int {
if m.ActiveValidatorCount == 0 {
return big.NewInt(0)
}
return big.NewInt(0).Div(m.NodeBond, big.NewInt(int64(m.ActiveValidatorCount)))
}

Expand Down
14 changes: 9 additions & 5 deletions shared/services/rewards/generator-impl-v11.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,12 +580,16 @@ func (r *treeGeneratorImpl_v11) calculateEthRewards(checkBeaconPerformance bool)
// Repeat, for megapools
if nodeInfo.Megapool != nil {
megapool := nodeInfo.Megapool
details := r.networkState.MegapoolDetails[megapool.Address]
// Skip megapools with no active validators (all exited/dissolved)
if details.ActiveValidatorCount == 0 {
continue
}
nodeFee := r.networkState.NetworkDetails.MegapoolRevenueSplitTimeWeightedAverages.NodeShare
voterFee := r.networkState.NetworkDetails.MegapoolRevenueSplitTimeWeightedAverages.VoterShare
pdaoFee := r.networkState.NetworkDetails.MegapoolRevenueSplitTimeWeightedAverages.PdaoShare
bond := details.GetMegapoolBondNormalized()
for _, validator := range megapool.Validators {
details := r.networkState.MegapoolDetails[megapool.Address]
bond := details.GetMegapoolBondNormalized()
nodeFee := r.networkState.NetworkDetails.MegapoolRevenueSplitTimeWeightedAverages.NodeShare
voterFee := r.networkState.NetworkDetails.MegapoolRevenueSplitTimeWeightedAverages.VoterShare
pdaoFee := r.networkState.NetworkDetails.MegapoolRevenueSplitTimeWeightedAverages.PdaoShare

// The megapool score is given by:
// (bond + effectiveNodeFee*(32-bond)) / 32
Expand Down
Loading