Add addListeners / removeListeners with configurable keyboard shortcuts#14
Open
math-krish wants to merge 1 commit intorocicorp:mainfrom
Open
Add addListeners / removeListeners with configurable keyboard shortcuts#14math-krish wants to merge 1 commit intorocicorp:mainfrom
math-krish wants to merge 1 commit intorocicorp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
I just want to say, I love your implementation! I'm not entirely sure if this works in replicache, but I tested it with a plain react application. Please let me know if there's anything you'd like me to change
What’s Changed
Adds optional keyboard shortcut support to UndoManager via two new methods:
New Constructor Options
Key Binding Type
KeyBinding is typed as a subset of the browser’s native KeyboardEventInit:
key
shiftKey
altKey
ctrlKey
metaKey
No extra dependencies — fully standard.
Platform Detection
Uses event.metaKey and event.ctrlKey directly from the event.
No deprecated navigator.platform.
Example
Testing
11 new unit tests covering:
Default shortcuts
Custom bindings
enableShortcuts: false
metaKey vs ctrlKey paths
removeListeners cleanup