fix(zero-client): ignore rows from unknown tables#5714
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
grgbkr
force-pushed
the
grgbkr/bumped-cvr-logging
branch
from
f3e4bd5 to
591b264
Compare
|
Bencher Report| Branch | grgbkr/bumped-cvr-logging |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 1,940.33 KB(+0.04%)Baseline: 1,939.57 KB | 1,978.36 KB (98.08%) |
| zero.js | 📈 view plot 🚷 view threshold | 279.58 KB(+0.03%)Baseline: 279.51 KB | 285.10 KB (98.07%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 74.13 KB(+0.07%)Baseline: 74.08 KB | 75.56 KB (98.11%) |
|
| Branch | grgbkr/bumped-cvr-logging |
| Testbed | self-hosted-metal |
Click to view all benchmark results
| Benchmark | Throughput | operations / second (ops/s) |
|---|---|---|
| src/db/pg-copy.bench.ts > pg-copy benchmark > copy | 📈 view plot 🚷 view threshold | 23.99 ops/s |
|
| Branch | grgbkr/bumped-cvr-logging |
| Testbed | self-hosted-metal |
Click to view all benchmark results
| Benchmark | Throughput | Benchmark Result operations / second (ops/s) (Result Δ%) | Lower Boundary operations / second (ops/s) (Limit %) |
|---|---|---|---|
| src/client/custom.bench.ts > big schema | 📈 view plot 🚷 view threshold | 112,102.11 ops/s(+2.17%)Baseline: 109,724.44 ops/s | 100,809.58 ops/s (89.93%) |
| src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 1,257.02 ops/s(-10.97%)Baseline: 1,411.95 ops/s | 669.15 ops/s (53.23%) |
| src/client/zero.bench.ts > pk compare > pk = N | 📈 view plot 🚷 view threshold | 35,583.61 ops/s(-8.37%)Baseline: 38,835.95 ops/s | 24,598.84 ops/s (69.13%) |
| src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 2,179.36 ops/s(-2.32%)Baseline: 2,231.16 ops/s | 1,183.69 ops/s (54.31%) |
|
| Branch | grgbkr/bumped-cvr-logging |
| Testbed | self-hosted-metal |
Click to view all benchmark results
| Benchmark | Throughput | operations / second (ops/s) |
|---|---|---|
| src/size-of-value.bench.ts > getSizeOfValue performance > arrays > large array (100 items) | 📈 view plot 🚷 view threshold | 1,537,765.89 ops/s |
| src/size-of-value.bench.ts > getSizeOfValue performance > arrays > small array (10 items) | 📈 view plot 🚷 view threshold | 12,755,982.63 ops/s |
| src/size-of-value.bench.ts > getSizeOfValue performance > datasets > large dataset (100x512B) | 📈 view plot 🚷 view threshold | 38,634.10 ops/s |
| src/size-of-value.bench.ts > getSizeOfValue performance > datasets > small dataset (10x256B) | 📈 view plot 🚷 view threshold | 387,899.06 ops/s |
| src/size-of-value.bench.ts > getSizeOfValue performance > objects > nested object | 📈 view plot 🚷 view threshold | 3,433,001.39 ops/s |
| src/size-of-value.bench.ts > getSizeOfValue performance > objects > structured object (1KB) | 📈 view plot 🚷 view threshold | 3,939,989.77 ops/s |
| src/size-of-value.bench.ts > getSizeOfValue performance > objects > structured object (256B) | 📈 view plot 🚷 view threshold | 3,891,758.37 ops/s |
| src/size-of-value.bench.ts > getSizeOfValue performance > primitives > boolean | 📈 view plot 🚷 view threshold | 73,215,131.84 ops/s |
| src/size-of-value.bench.ts > getSizeOfValue performance > primitives > integer | 📈 view plot 🚷 view threshold | 64,000,692.22 ops/s |
| src/size-of-value.bench.ts > getSizeOfValue performance > primitives > null | 📈 view plot 🚷 view threshold | 72,357,409.60 ops/s |
| src/size-of-value.bench.ts > getSizeOfValue performance > primitives > string (100 chars) | 📈 view plot 🚷 view threshold | 782,574.16 ops/s |
| src/tdigest.bench.ts > TDigest Benchmarks > add | 📈 view plot 🚷 view threshold | 2.39 ops/s |
| src/tdigest.bench.ts > TDigest Benchmarks > addCentroid | 📈 view plot 🚷 view threshold | 1.88 ops/s |
| src/tdigest.bench.ts > TDigest Benchmarks > addCentroidList | 📈 view plot 🚷 view threshold | 1.92 ops/s |
| src/tdigest.bench.ts > TDigest Benchmarks > merge > addCentroid | 📈 view plot 🚷 view threshold | 30,858.83 ops/s |
| src/tdigest.bench.ts > TDigest Benchmarks > merge > merge | 📈 view plot 🚷 view threshold | 31,481.35 ops/s |
| src/tdigest.bench.ts > TDigest Benchmarks > quantile | 📈 view plot 🚷 view threshold | 2.32 ops/s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.rocicorp.dev/p/zero/issue/246645
Reproduced locally in zbugs, verified fix manually. The api server can now query tables unknown by the zero client's schema, without causing errors on the zero client. The client simply discards patch operations for tables that are not in its schema.