Merged
Conversation
…h query execution. Added extensive unit tests for cyclic data structures. Improved logging for circular reference warnings. Fixed linter issues and optimized imports.
…d run all unit tests, and since they currently fail, should prevent the push.
…rsion in cyclic data graphs.
MyPy complains that `override` should be imported from the typing_extensions package, but Python docs show that `override` exists in typing as of 3.12.
Owner
Author
|
Fixed import issue that caused tests to fail. |
Owner
Author
|
As the owner, I can verify the code does what I want it to do and passes all test successfully. Approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed unit tests for cyclic data graphs in the Evaluator and pretty_printer.
Fixed implementation issues to support these tests.