Skip to content

Add --export-autocrypt-key command to rnpkeys CLI and a test.#2386

Open
kaie wants to merge 1 commit intornpgp:mainfrom
kaie:cli/export-autocrypt-key
Open

Add --export-autocrypt-key command to rnpkeys CLI and a test.#2386
kaie wants to merge 1 commit intornpgp:mainfrom
kaie:cli/export-autocrypt-key

Conversation

@kaie
Copy link
Copy Markdown
Contributor

@kaie kaie commented Mar 30, 2026

  • Adds --export-autocrypt-key command to rnpkeys, producing Autocrypt-format output via rnp_key_export_autocrypt()
  • Fixes rnp_key_export_autocrypt not setting output->keep = true on success, which caused rnp_output_destroy to delete the output file
  • Adds rnpkeys_exportkey_autocrypt test covering round-trip export/import

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 54.16667% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.39%. Comparing base (83a987a) to head (66f6786).

Files with missing lines Patch % Lines
src/rnp/fficli.cpp 58.53% 17 Missing ⚠️
src/rnpkeys/rnpkeys.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2386      +/-   ##
==========================================
- Coverage   85.46%   85.39%   -0.07%     
==========================================
  Files         126      126              
  Lines       22711    22759      +48     
==========================================
+ Hits        19409    19435      +26     
- Misses       3302     3324      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant