fix(playground): make browser playground boot in repo dev mode#25
Open
GangWangAI wants to merge 1 commit intorivet-dev:mainfrom
Open
fix(playground): make browser playground boot in repo dev mode#25GangWangAI wants to merge 1 commit intorivet-dev:mainfrom
GangWangAI wants to merge 1 commit intorivet-dev:mainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the browser playground so the documented local dev flow works again.
This updates the playground dev server and worker bundling so
pnpm -C packages/playground devcan boot the browser runtime withoutfailing on unresolved workspace imports or runtime bridge loading.
Problem
The playground README says it can be started directly from the repo, but the
page failed to boot in browser dev mode:
secure-exec/browser@secure-exec/core/internal/bridgeactual browser worker implementation
That left the playground stuck with errors like:
Failed to resolve module specifier "secure-exec/browser"Failed to load bridge module from @secure-exec/coreChanges
@secure-exec/coreand@secure-exec/browserassets in the playground dev server
workspace packages from local
dist/outputpackages/secure-exec-browser/src/worker.tsinstead of the proxy worker entry
instead of leaving a runtime dynamic import behind
Why
The playground is intended to be runnable directly from this repository.
These changes make the repo-local dev path match the documented setup and keep
the worker self-contained enough for browser dev mode.
Validation
Attempted:
pnpm -C packages/playground build:assetsNote:
tsxIPC socket permissions(
listen EPERM ... tsx-*.pipe), so I could not complete end-to-endverification from the agent environment.